Fix mismatches found by Clang-4.0.

Reported on FreeBSD's bugzilla [1].
Unfortunately it is likely more issues remain.

[1]
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=2

Fix mismatches found by Clang-4.0.

Reported on FreeBSD's bugzilla [1].
Unfortunately it is likely more issues remain.

[1]
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1779672 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix by far the largest source of -Wtautological-undefined-compare
compile warnings.

The class definition for SdrMarkView in svx/inc/svx/svdmrkv.hxx
contains two inline methods that t

Fix by far the largest source of -Wtautological-undefined-compare
compile warnings.

The class definition for SdrMarkView in svx/inc/svx/svdmrkv.hxx
contains two inline methods that take a reference argument and
perform an &rArg == NULL test on it. The compiler warns that this
condition should always be false because dereferencing a NULL pointer
to generate a reference is not valid in C++ and a valid reference will
never be at address 0. Warnings are generated every time this header
is included in a .cxx file.

It turns out that there are no callers for the IsGluePoint() method,
so just comment out its definition.

It also turns out that all the callers of IsPointMarked() pass it
a dereferenced pointer, so convert IsPointMarked() to take a pointer
argument and modify all the callers to pass a pointer without
dereferencing it first.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758862 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Merge branches/gbuild-reintegration to trunk.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1755455 13f79535-47bb-0310-9956-ffa450edef68

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i125613# Insert Picture from file do not work
The patch restores the behavior, that Insert from file replaces the empty outline object in Impress
Patch by:Regina Henschel <rb.henschel@t-onli

#i125613# Insert Picture from file do not work
The patch restores the behavior, that Insert from file replaces the empty outline object in Impress
Patch by:Regina Henschel <rb.henschel@t-online.de>

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1650314 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i119287 corrected default style for draw objects created using UNO API

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1609118 13f79535-47bb-0310-9956-ffa450edef68

i124816 use correct layer for new object when converting

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1605069 13f79535-47bb-0310-9956-ffa450edef68

i121410 Secured usage of pTextGroup

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1604147 13f79535-47bb-0310-9956-ffa450edef68

#i124422# fix implicit conversions to pointer from bool/int32

implicit conversions from bool or int32 to pointer types are not a good idea
and clang>=3.4 or xcode>=5.1 now report errors

#i124422# fix implicit conversions to pointer from bool/int32

implicit conversions from bool or int32 to pointer types are not a good idea
and clang>=3.4 or xcode>=5.1 now report errors for such code. The errors break
the build and so they have to be fixed.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1594864 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i63399 add to clipboard as URL only when no fill and no line style, just a simple URL

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1589094 13f79535-47bb-0310-9956-ffa450edef

i63399 add to clipboard as URL only when no fill and no line style, just a simple URL

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1589094 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Resync/update with trunk as preparation to integration

git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/alg_writerframes@1579184 13f79535-47bb-0310-9956-ffa450edef68

#i123770# obsolete and remove the emulation of hash_map's data_type typedef

and fix its former usages by utilizing the standard compliant mapped_type
typedef instead


git-sv

#i123770# obsolete and remove the emulation of hash_map's data_type typedef

and fix its former usages by utilizing the standard compliant mapped_type
typedef instead


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1575260 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i57936 Added refresh to update LayerTabBar when attributes like Layer visibility were set

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1573062 13f79535-47bb-0310-9956-ffa450

i57936 Added refresh to update LayerTabBar when attributes like Layer visibility were set

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1573062 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i87182 secured usage of LayerTabBar in Draw application, ensured initialization when used as OLE

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1572807 13f79535-47bb-0310-9956

i87182 secured usage of LayerTabBar in Draw application, ensured initialization when used as OLE

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1572807 13f79535-47bb-0310-9956-ffa450edef68

show more ...

123197: Fixed selection problems when switching between normal and master mode.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1570539 13f79535-47bb-0310-9956-ffa450edef68

i123468 Added SdrEndTextEdit before replacing EmptyPresObj, also secured ReplaceObjectAtView to check for active TextEdit, assert this and make an emergency correction

git-svn-id: https://sv

i123468 Added SdrEndTextEdit before replacing EmptyPresObj, also secured ReplaceObjectAtView to check for active TextEdit, assert this and make an emergency correction

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1569029 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i42894 added support for <presentation:animations> at import and creation

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1568575 13f79535-47bb-0310-9956-ffa450edef68

i123922 Refactored D&D and insert picture from file in all apps for all object types to work the same

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1565510 13f79535-47bb-0310

i123922 Refactored D&D and insert picture from file in all apps for all object types to work the same

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1565510 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i124085 disabled CF_DIBV5 (no advantages but some problems), increased png support

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1562493 13f79535-47bb-0310-9956-ffa450edef68

#i124131# use smart pointer's bool operator instead of comparing its content against NULL

this makes the code more typesafe and avoids the -Wnull-conversion warnings
seen with boost>=1.5

#i124131# use smart pointer's bool operator instead of comparing its content against NULL

this makes the code more typesafe and avoids the -Wnull-conversion warnings
seen with boost>=1.55 smart pointers in C+11 enabled build environments


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1562080 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i123817# boost::shared_ptr doesn't have an implicit conversion to bool

Constructs that expect it fail at least in XCode4's clang in C++11 mode.
An implicit conversion from pointer to bo

#i123817# boost::shared_ptr doesn't have an implicit conversion to bool

Constructs that expect it fail at least in XCode4's clang in C++11 mode.
An implicit conversion from pointer to bool is already suspicious enough
and a shared_ptr->pointer->bool conversion is even worse. Cleaning up
the code fixes the build breaker seen in boost/libc++/clang environments.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1560020 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i122221# fix slide selected in Slide Pane with Page Up

The comment in the removed part says to call SelectPage to make
the slide visible. But the following NotifyCurrentSlideChange meth

#i122221# fix slide selected in Slide Pane with Page Up

The comment in the removed part says to call SelectPage to make
the slide visible. But the following NotifyCurrentSlideChange method
calls SelectPage for the page makes it visible if the pane is not updated yet.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1559671 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i56998# use FUNIT_PERCENT instead of FUNIT_CUSTOM with parcent CustomUnitText on metric fields

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1559496 13f79535-47bb-0310-9956-

#i56998# use FUNIT_PERCENT instead of FUNIT_CUSTOM with parcent CustomUnitText on metric fields

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1559496 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i56998# add a space separater between value and unit and remove separator between value and percent to match with ISO 31-0

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1559

#i56998# add a space separater between value and unit and remove separator between value and percent to match with ISO 31-0

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1559327 13f79535-47bb-0310-9956-ffa450edef68

show more ...