History log of /trunk/main/toolkit/source/ (Results 1 - 25 of 41)
Revision (<<< Hide revision tags) (Show revision tags >>>)Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
cdfa2a0e01-Apr-2024 John Bampton

Fix spelling in comments (#209)

Revision tags: AOO420-Dev5-m5, AOO4115-GA, AOO4114-GA, AOO420-Dev4-m4, AOO4113-GA, AOO4112-GA, AOO4111-GA, AOO420-Dev3-m3, AOO4110-GA, AOO419-GA, AOO418-GA
2e3a1b6e18-Aug-2020 mseidel

Fixed typos (Normaly -> Normally) and some more

7950f2af14-Jun-2020 mseidel

Fixed typos (the the -> the) and some more

Revision tags: 420-Dev2-m2, AOO417, AOO420-Dev-m1, AOO416, AOO416-RC1
a8f4084d31-May-2018 Matthias Seidel

Fixed typos:
contructor -> constructor
convinient -> convenient

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1832633 13f79535-47bb-0310-9956-ffa450edef68

Revision tags: AOO415
5e0f18e305-Feb-2018 Don Lewis

A number of methods in main/toolkit/source/layout/vcl/* use either
"!this" or "this" in a boolean context in order to detect being
called with a null object and exit early. In a valid C++ pr

A number of methods in main/toolkit/source/layout/vcl/* use either
"!this" or "this" in a boolean context in order to detect being
called with a null object and exit early. In a valid C++ program
"this" will never be null, so a compiler could legally optimize out
this comparision, which could potentially result in the method
dereferencing a null pointer later in the code. This situation
could only happen if the caller is using a null object pointer to
call the method or is using a object ref to call the method that
was generated by dereferencing a null pointer, neither of which is
valid. Resolve this by moving the checks out of the method and
into the caller.

Make this easier by changing the getImpl() method to return the
private *Impl pointer directly instead of deferencing the pointer
and returning a ref. The latter is invalid if the pointer is null.
This allows GetImpl() to be called in a boolean contect to peform
the check. It also allows a number of instances of "&getImpl()"
calls in a boolean context to be fixed by changing them to "getImpl()".
The address of a ref will never be zero in a valid C++ program, so
the compiler could potentially optimize out those checks.

There does not appear to be any need for Control and ComboBox to
use customized versions of GetImpl() since these appear to behave
identically to the versions generated by the canned macro, so switch
them back to the macro version.

This commit should result in no functional changes.

It seems like all of these checks for a null implementation should
not be necessary, but that requires further investigation.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Revision tags: AOO414, AOO413, AOO4121, AOO412, SNAPSHOT, AOO411
874957b926-Jan-2015 Tsutomu Uchino

#i98734# store and load ScaleMode property of image control on dialogs

Suggested by: Frank Schönheit <frank.schoenheit@gmx.de>

git-svn-id: https://svn.apache.org/repos/asf/openoffic

#i98734# store and load ScaleMode property of image control on dialogs

Suggested by: Frank Schönheit <frank.schoenheit@gmx.de>

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744 13f79535-47bb-0310-9956-ffa450edef68

show more ...

c3ef676a16-May-2014 Tsutomu Uchino

#i98216# extract boolean value for AutoFill value of ComboBox model

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1595141 13f79535-47bb-0310-9956-ffa450edef68

86e1cf3429-Apr-2014 Pedro Giffuni

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Revision tags: AOO410, AOO410_Beta
3d76282606-Jan-2014 Herbert Dürr

#i123817# prepare codebase for updating to boost 1.55


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555789 13f79535-47bb-0310-9956-ffa450edef68

33b461d603-Jan-2014 Herbert Dürr

#i123963# remove type ambiguity in toolkit's VCLXDevice


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555077 13f79535-47bb-0310-9956-ffa450edef68

030daa2520-Dec-2013 Jürgen Schmidt

#120358# apply patch to support properties from tab model

Patch By: hanya
Review By: jsc


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1552621 13f79535-47bb

#120358# apply patch to support properties from tab model

Patch By: hanya
Review By: jsc


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1552621 13f79535-47bb-0310-9956-ffa450edef68

show more ...

bde8a4bd02-Dec-2013 Herbert Dürr

#i123795# variable names should not confuse vcl Window and cocoa NSWindow types

VCL's Window type and Cocoa's NSWindow type are quite different.
Naming variables as if they were the same

#i123795# variable names should not confuse vcl Window and cocoa NSWindow types

VCL's Window type and Cocoa's NSWindow type are quite different.
Naming variables as if they were the same introduces gratuitous
complexity especially when debugging stacks where both types are used.
The names of NSView type variables have been adjusted too.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1547078 13f79535-47bb-0310-9956-ffa450edef68

show more ...

24c56ab928-Nov-2013 Herbert Dürr

#i123068# remove implicit conversions from rtl strings to their elements

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546390 13f79535-47bb-0310-9956-ffa450edef68

4d7c9de028-Nov-2013 Herbert Dürr

#i123768# [ia2] remove pseudo-automatic noisy comments


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546355 13f79535-47bb-0310-9956-ffa450edef68

Revision tags: AOO401
d3e0dd8e02-Sep-2013 Steve Yin

Merged with the trunk.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1519381 13f79535-47bb-0310-9956-ffa450edef68


Revision tags: AOO400
31d843d725-May-2013 Ariel Constenla-Haile

i121542 - css::awt::XPopupMenu::execute() needs a css::awt::Rectangle

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1486375 13f79535-47bb-0310-9956-ffa450edef68

6fa810f301-Feb-2013 Steve Yin

IAccessible2 for AOO UI. This is the first version for QA.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1441343 13f79535-47bb-0310-9956-ffa450edef68


21075d7725-Jan-2013 Steve Yin

Draft version for IA2 UI file merge. Not ready for UT.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1438336 13f79535-47bb-0310-9956-ffa450edef68

45fd3b9a10-Jan-2013 Armin Le Grand

#121504# Support for alpha channel in clipboard for all systems

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1431512 13f79535-47bb-0310-9956-ffa450edef68

ff7e158d06-Jan-2013 Steve Yin

IA2 migration for toolkit module

git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1429484 13f79535-47bb-0310-9956-ffa450edef68

9807c9de04-Jan-2013 Ariel Constenla-Haile

i121578 - Convert css.system.SystemShellExectue to new-style

Adapt the office code to use the new-style service constructor

git-svn-id: https://svn.apache.org/repos/asf/openoffice/t

i121578 - Convert css.system.SystemShellExectue to new-style

Adapt the office code to use the new-style service constructor

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1429072 13f79535-47bb-0310-9956-ffa450edef68

show more ...

6116126824-Dec-2012 Ariel Constenla-Haile

i121544 - Clean-up MessageBox API

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1425608 13f79535-47bb-0310-9956-ffa450edef68

b6dc695e23-Dec-2012 Ariel Constenla-Haile

i121162 - ImageScaleMode constants should be in UPPERCASE

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1425511 13f79535-47bb-0310-9956-ffa450edef68

d026be4023-Dec-2012 Ariel Constenla-Haile

i121542 - Unify the Menu API

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1425458 13f79535-47bb-0310-9956-ffa450edef68

e821fb7720-Dec-2012 Ariel Constenla-Haile

i121514 - Remove deprecated UnoControlSimpleAnimation

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1424324 13f79535-47bb-0310-9956-ffa450edef68

12