Removed strings for de, cs and sk, cleanupgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1846316 13f79535-47bb-0310-9956-ffa450edef68
Fixed typos: contructor -> constructor convinient -> convenientgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1832633 13f79535-47bb-0310-9956-ffa450edef68
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"t
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"this" will never be null, so a compiler could legally optimize outthis comparision, which could potentially result in the methoddereferencing a null pointer later in the code. This situationcould only happen if the caller is using a null object pointer tocall the method or is using a object ref to call the method thatwas generated by dereferencing a null pointer, neither of which isvalid. Resolve this by moving the checks out of the method andinto the caller.Make this easier by changing the getImpl() method to return the private *Impl pointer directly instead of deferencing the pointerand returning a ref. The latter is invalid if the pointer is null.This allows GetImpl() to be called in a boolean contect to peformthe check. It also allows a number of instances of "&getImpl()"calls in a boolean context to be fixed by changing them to "getImpl()".The address of a ref will never be zero in a valid C++ program, so the compiler could potentially optimize out those checks.There does not appear to be any need for Control and ComboBox to use customized versions of GetImpl() since these appear to behaveidentically to the versions generated by the canned macro, so switchthem back to the macro version.This commit should result in no functional changes.It seems like all of these checks for a null implementation shouldnot be necessary, but that requires further investigation.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68
show more ...
Merge branches/gbuild-reintegration to trunk.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1755455 13f79535-47bb-0310-9956-ffa450edef68
writerperfect is no more.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1735186 13f79535-47bb-0310-9956-ffa450edef68
i126369 - Finish off hwpfilterThe Hangul Word Processor filter was disabled from OpenOffice in r1677190 due to security concerns. While some extra buffer controlscould have been made and the fil
i126369 - Finish off hwpfilterThe Hangul Word Processor filter was disabled from OpenOffice in r1677190 due to security concerns. While some extra buffer controlscould have been made and the filter restored, the truth is a muchbigger effort is required to catch up with this format. Files createdwith later editions of Hangul, including Hangul Wordian, Hangul 2002,Hangul 2005 and Hangul 2007 cannot be opened with the existing filter. Existing users can apparently download a free viewer and convert theirdocument to RTF or doc.Drop completely the code. while here also drop remnants of wpd supportthat we dropped since 3.4.1. Having less code is sometimes better.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1730107 13f79535-47bb-0310-9956-ffa450edef68
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744 13f79535-47bb-0310-9956-ffa450edef68
#i98216# extract boolean value for AutoFill value of ComboBox modelgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1595141 13f79535-47bb-0310-9956-ffa450edef68
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the internationa
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the international nature of the code butit is somewhat shameful that this wasn't done before.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68
#i123817# prepare codebase for updating to boost 1.55git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555789 13f79535-47bb-0310-9956-ffa450edef68
#i123963# remove type ambiguity in toolkit's VCLXDevicegit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555077 13f79535-47bb-0310-9956-ffa450edef68
#120358# apply patch to support properties from tab modelPatch By: hanyaReview By: jsc git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1552621 13f79535-47bb-0310-9956-ffa450edef68
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces gratuitouscomplexity especially when debugging stacks where both types are used.The names of NSView type variables have been adjusted too.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1547078 13f79535-47bb-0310-9956-ffa450edef68
#i123068# remove implicit conversions from rtl strings to their elementsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546390 13f79535-47bb-0310-9956-ffa450edef68
#i123768# [ia2] remove pseudo-automatic noisy commentsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546355 13f79535-47bb-0310-9956-ffa450edef68
Merged with the trunk.git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1519381 13f79535-47bb-0310-9956-ffa450edef68
#122356# rename toolkit lib due to conflicts on MacOS, it's a workaround for conflicts with sqlite..., will be probably solved with dropping mozilla libsgit-svn-id: https://svn.apache.org/repos/asf
#122356# rename toolkit lib due to conflicts on MacOS, it's a workaround for conflicts with sqlite..., will be probably solved with dropping mozilla libsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1488119 13f79535-47bb-0310-9956-ffa450edef68
i121542 - css::awt::XPopupMenu::execute() needs a css::awt::Rectanglegit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1486375 13f79535-47bb-0310-9956-ffa450edef68
IAccessible2 for AOO UI. This is the first version for QA.git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1441343 13f79535-47bb-0310-9956-ffa450edef68
Draft version for IA2 UI file merge. Not ready for UT.git-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1438336 13f79535-47bb-0310-9956-ffa450edef68
#121504# Support for alpha channel in clipboard for all systemsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1431512 13f79535-47bb-0310-9956-ffa450edef68
IA2 migration for toolkit modulegit-svn-id: https://svn.apache.org/repos/asf/openoffice/branches/ia2@1429484 13f79535-47bb-0310-9956-ffa450edef68
i121578 - Convert css.system.SystemShellExectue to new-styleAdapt the office code to use the new-style service constructorgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1429072 13f
i121578 - Convert css.system.SystemShellExectue to new-styleAdapt the office code to use the new-style service constructorgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1429072 13f79535-47bb-0310-9956-ffa450edef68
i121544 - Clean-up MessageBox APIgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1425608 13f79535-47bb-0310-9956-ffa450edef68
i121162 - ImageScaleMode constants should be in UPPERCASEgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1425511 13f79535-47bb-0310-9956-ffa450edef68
12345