In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's
table:number-columns-repeated attribute has a default value of 1,
meaning the cell spans the cell to its right. However when the

In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's
table:number-columns-repeated attribute has a default value of 1,
meaning the cell spans the cell to its right. However when the XSLT import
filter converts from SpreadsheetML's ss:MergeAcross to ODF's
table:number-columns-repeated, it always inserts a <table:covered-table-cell>
element, and then adds the table:number-columns-repeated attribute only if
it is greater than 1. This breaks when ss:MergeAcross="0", because ODF's
defaulting to 1 ends up occupying an extra empty cell to the right when it
shouldn't.

Fix this by only inserting the <table:covered-table-cell> when
ss:MergeAcross > 0.

Add a test document to prove this.

Fixes #100989 - SpreadsheetML: cell with ss:MergeAcross="0" gets an extra empty cell to the right
Patch by: me

(cherry picked from commit a896732bfcd282115c06407a2f1da77694fa8d19)

show more ...

When importing SpreadsheetML ss:DateTime, import the entire value, not only the
first 19 characters.

Add a test file for this bug.

Fixes: #128554 - Office 2003 SpreadsheetML: fractional seconds are

When importing SpreadsheetML ss:DateTime, import the entire value, not only the
first 19 characters.

Add a test file for this bug.

Fixes: #128554 - Office 2003 SpreadsheetML: fractional seconds are silently
ignored during import
Patch by: me

(cherry picked from commit 195282cf3d8bfaa9e1cec43b093251d9df87f4ba)

show more ...

Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing
conversion from R1C1 style column references to our A1 style references, had a
bug where it was treating the column value

Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing
conversion from R1C1 style column references to our A1 style references, had a
bug where it was treating the column value as 0-based, and dividing by 26 to
find the 1st letter and taking the remainder when divided by 26 for the second
letter. Those numbers are then each converted to a letter [0 = nothing,
1 = "A", 2 = "B", ..., 26 = "Z"].

However since R1C1 is 1-based, and not 0-based, this breaks for column numbers
which are multiples of 26, as 26 mod 26 = 0, so the least significant digit is
converted to nothing while the most significant digit gets incremented too
early.

Fix this by converting the column number to 0-based by subtracting 1 before
calculation, then adding 1 to the least significant digit afterwards.

Also the fact we have 2 letters limited us to a maximum of 26^2 = 676 columns,
after which column references would wrap around. Fix this too, by adding a 3rd
letter, which lets us address a maximum of 17576 columns.

Add a sample file to our unit tests.

Found by: alex dot plantema at xs4all dot nl
Patch by: me

(cherry picked from commit 577fe17932e0dec38662067d1a86e7fd6ae525b6)

show more ...

added test spreadsheet for single line comments and added it to test

Refs #i112383# and #i117960#. backporting to AOO41X .

Can't cherry-pick due to file changes.

Original commit messages and links follow:

Found-by: andrew
Patch-by: Damjan Jovanovic
https://github.c

Refs #i112383# and #i117960#. backporting to AOO41X .

Can't cherry-pick due to file changes.

Original commit messages and links follow:

Found-by: andrew
Patch-by: Damjan Jovanovic
https://github.com/apache/openoffice/commit/323c350123d05cd9f450aebd421b7bfa74c331d2

i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = 'hi'),
but also caused a regression where "Line Input" is broken in single-line If statements.
This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to
immediately preceed the 'Line' token in order for that 'Line' token to be recognized a keyword instead
of a variable name. Also added FVT spreadsheet tests for 'Line' as both a variable name and as 'Line Input'.
Patch by: Damjan Jovanovic
https://github.com/apache/openoffice/commit/725d867363770a4c47c4b3c6dbe1f359c296604a

show more ...