Fix crash, uninitialized-return, and buffer bugs in update check and macOS x86 bridge

updateprotocol.cxx: guard XNodeList dereferences so a swallowed
XPathException no longer leaves a null reference

Fix crash, uninitialized-return, and buffer bugs in update check and macOS x86 bridge

updateprotocol.cxx: guard XNodeList dereferences so a swallowed
XPathException no longer leaves a null reference to be dereferenced
(crash on malformed/hostile update descriptors); clear the list before
the relnote query so a thrown exception can't leave us iterating the
previous (sources) node list.

cpp2uno.cxx: the queryInterface fast-path guard used 'break', which
exited the switch and skipped the default case, returning an
uninitialized typelib_TypeClass. Guard the block with
'if (bHasHiddenReturn)' instead so control falls through to default and
eRet is always assigned.

updatecheck.cxx (getImageFromFileName): use bitwise '|' instead of
logical '||' when combining osl_Process flags; rewrite the trailing
CR/LF trim so it never reads/writes before the start of the buffer
(e.g. when osl_readFile returns 0 bytes).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

show more ...

Search for updates in the main thread. (#427)

Bypass and remove class InitUpdateCheckJobThread.
Updates are not checked automatically any more.
Also, lock the Solar Mutex whenever accessing the GUI.

Search for updates in the main thread. (#427)

Bypass and remove class InitUpdateCheckJobThread.
Updates are not checked automatically any more.
Also, lock the Solar Mutex whenever accessing the GUI.

(cherry picked from commit b838f7250280accb8f6cdc9cbe4a034b657b83c5)

show more ...

pre-commit whitespace cleanup for `.component` files (#398)

Enforced 3 hooks for `.component` files:

- end-of-file-fixer
- mixed-line-ending
- trailing-whitespace

(cherry picked from commit 85e7a2

pre-commit whitespace cleanup for `.component` files (#398)

Enforced 3 hooks for `.component` files:

- end-of-file-fixer
- mixed-line-ending
- trailing-whitespace

(cherry picked from commit 85e7a208034f6237c454f4b97c228cc5be6146df)

show more ...

pre-commit auto remove trailing whitespace from cxx files (#383)

Another big auto clean up. So many lines !!

Another one bites the dust

https://www.youtube.com/watch?v=rY0WxgSXdEE

Co-authored-by:

pre-commit auto remove trailing whitespace from cxx files (#383)

Another big auto clean up. So many lines !!

Another one bites the dust

https://www.youtube.com/watch?v=rY0WxgSXdEE

Co-authored-by: Matthias Seidel <mseidel@apache.org>
(cherry picked from commit cf6516809c57e1bb0a940545cca99cdad54d4ce2)

show more ...