| #
8cabe4bf
|
| 29-Aug-2026 |
Peter Kovacs <petko@apache.org> |
pre-commit: make the --all-files run green again
.github/workflows/pre-commit.yml runs `pre-commit run --all-files` on every
pull request, so three hooks were failing every PR regardless of what it
pre-commit: make the --all-files run green again
.github/workflows/pre-commit.yml runs `pre-commit run --all-files` on every
pull request, so three hooks were failing every PR regardless of what it
touched:
trim trailing whitespace.............................Failed (83 files)
makes sure files end in a newline and only a newline.Failed (31 files)
run codespell........................................Failed (2 files)
Whitespace, 88 files across chart2, connectivity and officecfg. Most of the
trailing blanks are the "# " lines inside the ASF licence header of a
gbuild makefile; the end-of-file ones are a second blank line after the vim
modeline. Produced by running the hooks, not by hand:
pre-commit run trailing-whitespace --all-files
pre-commit run end-of-file-fixer --all-files
`git diff --ignore-all-space --ignore-blank-lines` over that part of this
commit is empty, so no byte a compiler, dmake or gbuild reads has changed.
Codespell, two findings, treated differently because only one is a typo:
* connectivity/Library_dbtools.mk:168 "depenedencies" -> "dependencies",
in a comment.
* bridges/.../rtti_crossdylib_test/thrower.cxx "nodel" is the no-op
deleter handed to __cxa_throw -- a deliberate abbreviation, not a
misspelling. Added to .github/linters/codespell.txt, which is what that
list is for; renaming a function to satisfy a spell checker is the wrong
way round.
The three fixes are one commit rather than three because they are not
separable: the typo is in Library_dbtools.mk, which is also one of the 88
whitespace files, and pre-commit checks the staged content -- so a commit
carrying either fix alone fails its own hooks.
After this, `pre-commit run --all-files` passes every hook.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWgzQY2r1XwFvgeLPFWPsi
show more ...
|
| #
861c4860
|
| 17-Jan-2025 |
Damjan Jovanovic <damjan@apache.org> |
Implement JAR sealing and RegistrationClassName in Ant.
Port the Java modules in connectivity to build with Ant.
Add hsqldb as an Ant external.
Add the Configuration files in connectivity to gbuild.
Implement JAR sealing and RegistrationClassName in Ant.
Port the Java modules in connectivity to build with Ant.
Add hsqldb as an Ant external.
Add the Configuration files in connectivity to gbuild.
Connectivity configuration postprocess packaging w/o zip files.
Fixes to naming, paths in postpostprocess.
AllLangResTarget for chart2.
Patch by: me
show more ...
|