| e395a223 | 25-Jul-2026 |
Peter Kovacs <petko@apache.org> |
crashrep: arch-guard dwRelOffset so x86 keeps building (Win64 regression)
Win64 commit d14d772a5b changed `DWORD dwRelOffset` to `DWORD64`
unconditionally in WriteStackFile(). That is required on x
crashrep: arch-guard dwRelOffset so x86 keeps building (Win64 regression)
Win64 commit d14d772a5b changed `DWORD dwRelOffset` to `DWORD64`
unconditionally in WriteStackFile(). That is required on x64 (where the
dbghelp macro maps SymGetSymFromAddr to SymGetSymFromAddr64, whose
displacement parameter is PDWORD64) but breaks the x86 build, where the
non-64 SymGetSymFromAddr wants a PDWORD:
soreport.cpp(1789) : error C2664: 'SymGetSymFromAddr' : cannot convert
parameter 3 from 'DWORD64 *' to 'PDWORD'
Select the displacement type per architecture with the same INTEL/X86_64
guard the commit already uses for the CONTEXT.Eip/Rip assignment a few
lines above, so both x86 (DWORD) and x64 (DWORD64) compile.
Pure source fix, backportable to the dmake tree.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 4eacc145a1370da7bc62c999e62d01503b1227eb)
show more ...
|